fix: Handle calc() with number type in CSS position checking#494
Merged
Conversation
Bug: A conic-gradient() position containing a calc() that resolves to a number causes a ClassCastException to be thrown. Cause: CssCalc.getLength() only handled computed_type == CSS_LENGTH. When CssBackgroundPosition.checkSyntax() calls getLength() on a calc with computed_type == CSS_NUMBER, it falls through to the throw. Fix: Delegate to the inner value’s getLength() when computed_type is CSS_NUMBER, matching how CssNumber.getLength() handles the zero-check.
Member
|
Good catch, I'll add other types where zero is a valid entry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: A
conic-gradient()position containing acalc()that resolves to a number causes aClassCastExceptionto be thrown.Cause:
CssCalc.getLength()only handledcomputed_type == CSS_LENGTH. WhenCssBackgroundPosition.checkSyntax()callsgetLength()on a calc withcomputed_type == CSS_NUMBER, it falls through to the throw.Fix: Delegate to the inner value's
getLength()whencomputed_typeisCSS_NUMBER, matching howCssNumber.getLength()handles the zero-check.The exception is reproducible by checking http://loconto.net