[css-paint-api] Add CanvasFilters to paint worklets#1055
Open
mysteryDate wants to merge 1 commit intow3c:mainfrom
Open
[css-paint-api] Add CanvasFilters to paint worklets#1055mysteryDate wants to merge 1 commit intow3c:mainfrom
mysteryDate wants to merge 1 commit intow3c:mainfrom
Conversation
Contributor
|
this lgtm - I'll quickly add an issue to put it on the adgenda to add. This was likely an oversight on my part initially. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is already implemented by chromium (the only existent implementation of css-paint-api):
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/csspaint/paint_rendering_context_2d.idl;l=41?q=paint_rendering_context_2d.idl&sq=package:chromium&ct=os
I do not see a reason why it should not be there, as all other features of CanvasRenderingContext2D are (except for fonts).