Skip to content

feat: color lines by special tag - #182

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:feat/tag-line-colors
Open

feat: color lines by special tag#182
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:feat/tag-line-colors

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 9, 2026

Copy link
Copy Markdown

Summary

  • add opt-in whole-line background colors for special tags through todo.colors.tags.lineBackground
  • select the first colored tag on each line deterministically while preserving existing status text colors and tag styling
  • repeat shorter base, dark, and light line-background palettes across all configured tags
  • document the setting and cover its schema, range selection, precedence, theme overrides, and short-palette fallback

Verification

  • npm test — passed: 231 tests
  • npm run compile — passed: webpack development build completed
  • npm run format:check — passed: all matched files use Prettier formatting
  • git diff --check upstream/develop...HEAD — passed

Risk

  • Low: the new palette defaults to empty, so existing decoration behavior is unchanged until configured.

Closes #93

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev vycdev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new special-tag palette needs to follow the palette fallback semantics already on develop.

Comment thread src/todo/decorators/tag.ts Outdated

SPECIAL_TAG_LINES = [];
Consts.tags.names.forEach((name, index) => {
const backgroundColor = Consts.colors.tags.lineBackground[index];

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current develop makes shorter special-tag palettes repeat across every configured tag. Indexing lineBackground directly means ['red'] colors only the first tag while the existing background/foreground palettes color all tags, and the dark/light arrays have the same issue below. Please use the shared palette helper for base, dark, and light line backgrounds and add a short-palette regression.

@vycdev2
vycdev2 force-pushed the feat/tag-line-colors branch from 4db757d to 3e3583d Compare August 15, 2026 01:07
@vycdev2

vycdev2 commented Aug 15, 2026

Copy link
Copy Markdown
Author

Addressed the short-palette feedback and rebased onto current develop. Whole-line base, dark, and light palettes now use the shared repeating palette helper, with a regression covering a third configured tag reusing a two-color palette.

Verification: npm test (231 passing), npm run compile, npm run format:check, and git diff --check upstream/develop...HEAD all pass. Updated commit: 3e3583d.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants