Skip to content

fix: support uncached robbery targets - #149

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/uncached-rob-target-20260818
Open

fix: support uncached robbery targets#149
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/uncached-rob-target-20260818

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • pass robbery targets through the existing IUser user-creation path instead of casting them to SocketUser
  • add a command-path regression test for REST-backed/uncached Discord users

Verification

  • dotnet test Morpheus.Tests/Morpheus.Tests.csproj --filter FullyQualifiedName~EconomyModuleTests --nologo — regression failed on the untouched behavior with InvalidCastException, then passed 1/1 after the fix
  • dotnet build --nologo — passed with 0 errors (2 existing SQLitePCLRaw.lib.e_sqlite3 vulnerability warnings)
  • dotnet test --no-build --nologo — passed: 429, skipped: 1, failed: 0
  • dotnet format Morpheus.sln --no-restore --include Modules/EconomyModule.cs Morpheus.Tests/EconomyModuleTests.cs --verify-no-changes — passed (workspace load warnings only)
  • git diff --check upstream/develop...HEAD — passed

Risk

  • Low — the production change removes an invalid narrowing cast and uses the IUser overload already used for uncached transfer recipients; the test harness is isolated to the test project.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant