Skip to content

fix: remove obsolete quote reaction permission - #146

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/quote-button-permission-20260817
Open

fix: remove obsolete quote reaction permission#146
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/quote-button-permission-20260817

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the obsolete Add Reactions bot-permission precondition from addquote and removequote now that approvals use interaction buttons
  • add regression coverage for both command registrations and regenerate COMMANDS.md

Verification

  • dotnet build — passed with 0 errors (2 existing SQLite package vulnerability warnings)
  • dotnet test --no-build --logger "console;verbosity=minimal" — passed: 430 passed, 1 skipped, 0 failed
  • dotnet test Morpheus.Tests/Morpheus.Tests.csproj --no-restore --filter FullyQualifiedName~QuoteCommandRegistrationTests --logger "console;verbosity=minimal" — passed: 2/2
  • python3 -m unittest tools.test_generate_commands_md — passed: 3/3
  • git diff --check — passed

Risk

  • Low: this only removes a permission gate that is no longer used by the button-based approval flow; posting failures remain handled by the existing cleanup/error path.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant