Skip to content

fix: prevent quote period score overflow - #140

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/quote-period-score-overflow-20260813
Open

fix: prevent quote period score overflow#140
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/quote-period-score-overflow-20260813

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • widen quote-of-the-period score aggregation before summing so large totals do not overflow database integer materialization
  • clamp the aggregate at the existing public int boundary, matching the other quote score paths
  • add a SQLite regression for a period total above Int32.MaxValue

Verification

  • focused RED on untouched behavior — failed with OverflowException for Int32.MaxValue + 1
  • focused regression test — passed (1/1)
  • dotnet build Morpheus.sln --no-restore --configuration Release — passed with 0 errors (existing SDK/package warnings)
  • dotnet test Morpheus.sln --no-build --configuration Release — passed: 429, skipped: 1, failed: 0
  • git diff --check — passed

Risk

  • Low: no schema or public API changes; this applies the repository’s existing widened-sum and clamping pattern to the missed period-query path.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant