Skip to content

fix: honor activity role job cancellation - #139

Merged
vycdev merged 1 commit into
vycdev:developfrom
vycdev2:fix/activity-roles-cancellation-20260813
Aug 23, 2026
Merged

fix: honor activity role job cancellation#139
vycdev merged 1 commit into
vycdev:developfrom
vycdev2:fix/activity-roles-cancellation-20260813

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • honor Quartz cancellation before loading activity-role guilds and while pacing role reconciliation
  • propagate cancellation through EF persistence instead of logging and continuing during host shutdown
  • add a regression test proving a pre-canceled execution exits with cancellation

Verification

  • dotnet build --no-restore --verbosity minimal — passed (0 errors; existing NU1903 SQLite package warning)
  • dotnet test Morpheus.Tests/Morpheus.Tests.csproj --no-build --filter FullyQualifiedName~ActivityRolesJobTests --logger 'console;verbosity=minimal' — passed (1/1)
  • dotnet test Morpheus.Tests/Morpheus.Tests.csproj --no-build --logger 'console;verbosity=minimal' — passed (429 passed, 1 skipped)
  • git diff --check upstream/develop...HEAD — passed
  • regression proof: the new test failed against untouched develop because no cancellation was propagated, then passed with this change

Risk

  • Low: the change affects only shutdown/interruption behavior; normal activity-role assignment logic is unchanged.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev
vycdev merged commit 8e484ea into vycdev:develop Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants