Open
Conversation
userquin
commented
Mar 19, 2026
Member
Author
|
Don't merge yet, we're adding support for Shiki |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the logic at Vuetify layout to the index.ts module, we don't need to create and mount a vue application for that.
This PR also includes:
addedanimated-logo.svgback but still not being used: I need to check why the SVG only runs the animation once, on page refresh the animation is missinganimated-logo.svgand use it at home hero: looks like it is not working withdev server, you need to rundocs:serve(build + vp preview) => there is some weird behavior, sometimes the animations are there sometimes missing (chrome, brave and firefox on Windows) when using the VP navigation or the back briwser button, on page refresh it works...Linked Issues
Additional Context
I've sent a PR to VitePress to include a new hero actions slot, this PR updates VP to v2 alpha 17 and uses the new slot
home-hero-actions-before-actionsto add thenpxinput box before VP actions list but inside actions container:vuejs/vitepress#5151
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.