Fix: three incorrect code examples in the guide#3418
Merged
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Problem
Three errors in code examples across the guide — see issue #3417 for full context.
1.
guide/essentials/reactivity-fundamentals— Stateful MethodsThe solution block uses
_.debounce(this.click, 500), but_is never imported. The preceding block in the same section already hasimport { debounce } from 'lodash-es', so calling_.debounceresults in aReferenceErrorat runtime.2.
guide/components/events— Declaring Emitted Events, Options APIThe Options API
emitsobject syntax example contains TypeScript type annotations but is fenced asjs. The Composition API counterpart directly above it correctly uses<script setup lang="ts">.3.
guide/components/v-model— Modifiers for v-model with Arguments, Options APIThe tag
<MyComponent v-model:title.capitalize="myText">is missing the self-closing/>. All other component tags on the page use/>.Proposed Solution
reactivity-fundamentals.md: replace_.debouncewithdebounceevents.md: change code fence fromjstotsv-model.md: add/>to close the component tagAdditional Information
Closes #3417