fix(devtools-kit): only treat own render property as component definition#1110
Open
lazerg wants to merge 1 commit into
Open
fix(devtools-kit): only treat own render property as component definition#1110lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1100.
As @skirtles-code pointed out in the issue, the state serializer treats any object with a
rendermethod as a Vue component definition, so plain class instances stored in Pinia state (whose class happens to define arendermethod) are shown as "Unknown component". A component definition keepsrenderas an own property, whereas a class instance inherits it from the prototype, so this checks for an ownrenderproperty — real component definitions are still detected, and ordinary objects are left alone.