Conversation
silvadenisaraujo
approved these changes
Sep 3, 2025
Contributor
silvadenisaraujo
left a comment
There was a problem hiding this comment.
Working with async writes works well and in my perspective solves the memory issue that we have today for large exports, I added comments if you want to go beyond and we could add a mechanism to handle retries and throttling efficiently.
filafb
approved these changes
Sep 3, 2025
filafb
left a comment
There was a problem hiding this comment.
LGTM. Just a comment about handling error in a more clear way, but not a blocker.
filafb
approved these changes
Sep 3, 2025
filafb
left a comment
There was a problem hiding this comment.
LGTM. Just a comment about error handling, but not a blocker at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
To improve the export feature, allowing accounts with a huge number of redirects to work (e.g. Americanas)
What problem is this solving?
Currently, Americanas has over 7M registered redirects. However, this plugin stored the redirects in memory, to only save them to a file in the end, causing OOM issues that can kill the OS. This PR changes the process to enqueue the paginated requests and write them to a file concurrently to requesting next pages, which allows a better memory management and avoids OOM issues.
Types of changes
Chores checklist
CHANGELOG.md