Feature displayMode select for Color Variation#1104
Open
mihaidanieldumitru wants to merge 1 commit intovtex-apps:masterfrom
Open
Feature displayMode select for Color Variation#1104mihaidanieldumitru wants to merge 1 commit intovtex-apps:masterfrom
mihaidanieldumitru wants to merge 1 commit intovtex-apps:masterfrom
Conversation
Contributor
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
645f421 to
659f596
Compare
659f596 to
0750245
Compare
0750245 to
e771353
Compare
e771353 to
2740bfa
Compare
2740bfa to
43cdcc9
Compare
43cdcc9 to
f3d7054
Compare
f3d7054 to
340be9d
Compare
340be9d to
82f68f5
Compare
82f68f5 to
f6d1007
Compare
f6d1007 to
52bcd76
Compare
afa116a to
61d6a0a
Compare
61d6a0a to
e95c134
Compare
e95c134 to
21b1810
Compare
21b1810 to
d10bfac
Compare
d10bfac to
12731fb
Compare
12731fb to
2371bf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
This feature is needed in order to render color variations inside shelves using a dropdown. Before the only way was a slider/list of buttons.
How to test it?
Workspace
Screenshots or example usage:
"product-summary-sku-selector#shelf": { "props": { "maxItems": 50, "displayMode": "select", "showVariationsLabels": "none", "initialSelection": "empty", "visibility": "more-than-one", "visibleVariations": ["Culoare"], + "displayModeSelectForColorVariation": true, "blockClass": "defaultShelf" } },