Fix macOS window embedding#1688
Merged
robertosfield merged 1 commit intovsg-dev:masterfrom Apr 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
MacOS_WindowignoresWindowTraits::nativeWindowand always creates a standaloneNSWindow, making it impossible to embed a VSG Vulkan surface into an existing view hierarchy (e.g. a QtQWindowviaQWidget::createWindowContainer).This change adds an embedded window path to
MacOS_Windowthat mirrors whatWin32_Windowalready does on Windows: whentraits->nativeWindowcontains a valid handle, the providedNSViewis used directly instead of creating a new NSWindow/NSView. ACAMetalLayeris attached to the external view if one doesn't already exist, and the Vulkan surface is created from it.Additionally,
pollEvents()skipsNSAppevent draining in the embedded case (the host framework owns the event loop), andresize()falls back to[_view window]forbackingScaleFactorwhen no standalone_windowexists.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
QWidget::createWindowContaineron macOS — surface creation, swapchain, rendering, and resize all function correctlyTest Configuration:
Checklist: