Skip to content

Allow options in objectToDocumentXML when calling a method (take 2) - #1509

Merged
w666 merged 13 commits into
vpulim:masterfrom
smokhov:feature-1096-ndeniche_override-base-element
Aug 1, 2026
Merged

Allow options in objectToDocumentXML when calling a method (take 2)#1509
w666 merged 13 commits into
vpulim:masterfrom
smokhov:feature-1096-ndeniche_override-base-element

Conversation

@smokhov

@smokhov smokhov commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This PR reformats #1096 (by @ndeniche) using current prettier rules and fixes its test to do what it's supposed to do clearing an earlier objection here, so the test only passes if overrideBaseElement is true.

@smokhov
smokhov marked this pull request as ready for review July 20, 2026 06:47
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 80c8d783-0e85-4bd1-8620-b0c430d0aad9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread test/client-test.js
@smokhov
smokhov requested a review from w666 July 29, 2026 20:56
@smokhov

smokhov commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@w666 -- added more coverage as you suggested and also realized that we had no mention of that in the README, so added there a section as well. Over to you.

@w666
w666 merged commit e602dc1 into vpulim:master Aug 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants