Refactor read driver as an explicit stream - #9395
Merged
Merged
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will regress 1 benchmark
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #9384.
ReadDriver<R>: Streamstate machineasync_streamresult adapter with an explicitReadRangeResultsstate machineIoRequestStreambefore yieldingReadRangeResultshas explicitReadingandMissingstates: it matches out-of-order range results while reading, then reports every unresolved request if the underlying stream ends early.When several results become ready together, the driver now resolves all of them and submits one refill group for the freed slots in the same poll. It does not add another FileReadAt or ObjectStore queue.
Validation
cargo +nightly fmt --all -- --checkcargo test -p vortex-file(142 passed; 1 doctest ignored)cargo clippy -p vortex-file --all-targets --all-features -- -D warningsRUSTDOCFLAGS='-D warnings --cfg docsrs' cargo doc --profile ci --no-deps --document-private-items -p vortex-file