Skip to content

Fix wasm32 build by gating MultiFileSession on non-wasm targets #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 2 commits into from
Jun 27, 2026
+5 −1
Merged

Fix wasm32 build by gating MultiFileSession on non-wasm targets #8612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff24840
fix(session): don't register MultiFileSession on wasm to avoid Instan…
claude Jun 27, 2026
87f538a
fix
robert3005 Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vortex/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,11 @@ impl VortexSessionDefault for VortexSession {
.with::<MemorySession>()
.with::<RuntimeSession>();

#[cfg(feature = "files")]
// `MultiFileSession` holds a `moka` cache whose clock reads `std::time::Instant::now()`
// when constructed. `Instant` is unsupported on `wasm32` and panics with "time not
// implemented on this platform". Multi-file scanning is not available on wasm anyway, so
// only register this session variable on non-wasm targets.
#[cfg(all(feature = "files", not(target_arch = "wasm32")))]
let session = {
let session = session.with::<file::multi::MultiFileSession>();
file::register_default_encodings(&session);
Expand Down
Loading