Handle nested list and struct layouts#8588
Draft
mhk197 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Merging this PR will improve performance by 13.73%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
154.8 µs | 191 µs | -18.98% |
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
26.7 µs | 16.1 µs | +65.44% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
259.1 µs | 223.8 µs | +15.76% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
305.7 µs | 270.6 µs | +12.97% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
273.6 ns | 244.4 ns | +11.93% |
| ⚡ | Simulation | eq_i64_constant |
318.1 µs | 288.4 µs | +10.31% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mk/table-list-layout (81e5176) with develop (4668b6e)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
github-actions
Bot
removed
the
action/benchmark-sql
mhk197
changed the title
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.397x ❌ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.397x ❌, 0↑ 10↓)
File Size Changes (1 files changed, +0.0% overall, 1↑ 0↓)
Totals:
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.020x ➖, 0↑ 0↓)
datafusion / parquet (0.964x ➖, 3↑ 0↓)
duckdb / vortex-file-compressed (1.035x ➖, 0↑ 1↓)
duckdb / parquet (1.030x ➖, 0↑ 0↓)
File Size Changes (3 files changed, -46.3% overall, 0↑ 3↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.127x ❌, 0↑ 18↓)
datafusion / parquet (1.085x ➖, 0↑ 7↓)
datafusion / arrow (1.097x ➖, 0↑ 11↓)
duckdb / vortex-file-compressed (1.167x ❌, 0↑ 20↓)
duckdb / parquet (1.069x ➖, 0↑ 5↓)
File Size Changes (18 files changed, -44.4% overall, 5↑ 13↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.983x ➖, 5↑ 5↓)
datafusion / parquet (0.949x ➖, 9↑ 0↓)
duckdb / vortex-file-compressed (0.967x ➖, 18↑ 8↓)
duckdb / parquet (0.982x ➖, 0↑ 1↓)
File Size Changes (36 files changed, -43.4% overall, 2↑ 34↓)
Totals:
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (1.019x ➖, 0↑ 0↓)
duckdb / parquet (1.028x ➖, 0↑ 0↓)
File Size Changes (3 files changed, -32.3% overall, 1↑ 2↓)
Totals:
|
Contributor
Benchmarks: Clickbench Sorted on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.933x ➖, 3↑ 0↓)
datafusion / parquet (1.001x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.923x ➖, 4↑ 0↓)
duckdb / parquet (0.995x ➖, 0↑ 0↓)
File Size Changes (201 files changed, -42.6% overall, 49↑ 152↓)
Totals:
|
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.995x ➖, 0↑ 0↓)
datafusion / parquet (1.081x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.139x ➖, 0↑ 2↓)
duckdb / parquet (1.006x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.027x ➖, 1↑ 1↓)
datafusion / parquet (1.028x ➖, 0↑ 0↓)
datafusion / arrow (1.044x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.046x ➖, 0↑ 2↓)
duckdb / parquet (1.014x ➖, 0↑ 0↓)
File Size Changes (48 files changed, -44.5% overall, 10↑ 38↓)
Totals:
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.942x ➖, 9↑ 3↓)
datafusion / parquet (1.151x ❌, 0↑ 27↓)
duckdb / vortex-file-compressed (0.911x ➖, 14↑ 1↓)
duckdb / parquet (0.984x ➖, 0↑ 0↓)
File Size Changes (201 files changed, -39.1% overall, 53↑ 148↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.891x ➖, 6↑ 3↓)
datafusion / parquet (0.994x ➖, 2↑ 4↓)
duckdb / vortex-file-compressed (1.040x ➖, 0↑ 1↓)
duckdb / parquet (0.998x ➖, 0↑ 1↓)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
TableStrategy::with_list_layout()for recursive list/list-of-struct layout writing