Skip to content

group ids as array ref, multi encoding kernel lookup#8550

Open
onursatici wants to merge 2 commits into
ngates/grouped-aggregatefrom
os/grouped-aggregate
Open

group ids as array ref, multi encoding kernel lookup#8550
onursatici wants to merge 2 commits into
ngates/grouped-aggregatefrom
os/grouped-aggregate

Conversation

@onursatici

Copy link
Copy Markdown
Contributor

Signed-off-by: Onur Satici onur@spiraldb.com

Summary

Closes: #000

Testing

Signed-off-by: Onur Satici <onur@spiraldb.com>
@codspeed-hq

codspeed-hq Bot commented Jun 23, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 14.43%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

#### 🎉 Hooray! `codspeed-rust` just leveled up to 5.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

⚡ 28 improved benchmarks
❌ 16 regressed benchmarks
✅ 1483 untouched benchmarks
⏩ 9 skipped benchmarks1
🗄️ 1 archived benchmark run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation compare[31] 157.9 µs 213.3 µs -25.98%
Simulation compare[30] 155.4 µs 209 µs -25.63%
Simulation compare[29] 153.6 µs 205.2 µs -25.18%
Simulation compare[28] 150.9 µs 200.7 µs -24.84%
Simulation compare[27] 149.5 µs 197.5 µs -24.28%
Simulation compare[26] 147.1 µs 193.2 µs -23.87%
Simulation compare[25] 145.3 µs 189.5 µs -23.32%
Simulation compare[24] 141.1 µs 183.5 µs -23.11%
Simulation compare[23] 140.9 µs 181.4 µs -22.33%
Simulation compare[22] 138.5 µs 177.1 µs -21.81%
Simulation compare[21] 136.7 µs 173.4 µs -21.18%
Simulation compare[20] 133.5 µs 168.5 µs -20.75%
Simulation compare[19] 132.3 µs 165.3 µs -19.97%
Simulation compare[18] 129.8 µs 161 µs -19.36%
Simulation count_i32_clustered_nulls 35 µs 40.8 µs -14.33%
Simulation encode_varbin[(1000, 2)] 158 µs 177.7 µs -11.09%
Simulation compare[63] 360.9 µs 244.9 µs +47.39%
Simulation compare[56] 328.2 µs 225 µs +45.86%
Simulation compare[62] 364.7 µs 250.3 µs +45.72%
Simulation compare[63] 371.9 µs 255.6 µs +45.5%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing os/grouped-aggregate (7c748a8) with ngates/grouped-aggregate (2ef64b2)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 1 benchmark was run, but is now archived. If it was deleted in another branch, consider rebasing to remove it from the report. Instead if it was added back, click here to restore it.

Comment thread vortex-array/src/aggregate_fn/fns/count/grouped.rs Outdated
Comment thread vortex-array/src/aggregate_fn/fns/sum/grouped.rs Outdated
Comment thread vortex-array/src/aggregate_fn/accumulator_grouped.rs Outdated
Comment thread vortex-array/src/aggregate_fn/kernels.rs Outdated
Comment thread vortex-array/src/aggregate_fn/session.rs Outdated
Signed-off-by: Onur Satici <onur@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants