Skip to content

ci: install only the uv binary for v4 ingest (drop the workspace sync) #8517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
connortsui20 wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

ci: install only the uv binary for v4 ingest (drop the workspace sync) #8517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,24 +136,22 @@ jobs:
# `continue-on-error` so an OIDC / uv / connect hiccup never breaks the v3
# pipeline. post-ingest.py mints the RDS IAM token internally (boto3) from
# the assumed GitHubBenchmarkIngestRole; sslmode=verify-full validates the cert.
#
# ORDER MATTERS: "Install uv" runs BEFORE "Configure AWS credentials".
# configure-aws-credentials persists the assumed ingest-role (rds-db:connect
# only) as the job's ambient AWS creds; the uv setup compiles via sccache
# (S3-backed), so running it after the role switch fails with S3 AccessDenied.
# Installing uv first keeps sccache on the original S3-capable creds; the role
# is assumed immediately before the ingest, which needs only rds-db:connect.
- name: Install uv for v4 ingest
if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
uses: spiraldb/actions/.github/actions/setup-uv@a746510eafaa926484c354541cfc49b2ec06cc63 # 0.18.6
- name: Configure AWS credentials for v4 ingest (OIDC)
if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
uses: aws-actions/configure-aws-credentials@e7f100cf4c008499ea8adda475de1042d6975c7b # v6
with:
role-to-assume: ${{ vars.GH_BENCH_INGEST_ROLE_ARN }}
aws-region: ${{ vars.RDS_BENCH_REGION }}
# Install ONLY the uv binary (no `uv sync`): the ingest runs
# `uv run --no-project --with`, which needs just the binary, not a workspace
# build. spiraldb's setup-uv ran a full `uv sync` that built vortex-python via
# sccache->S3 and failed under the ingest-role creds (which lack S3) -- pure
# waste, since the ingest never used the synced workspace.
- name: Install uv for v4 ingest
if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
- name: Ingest results to v4 Postgres (best-effort)
if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
Expand Down
20 changes: 9 additions & 11 deletions .github/workflows/commit-metadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,24 +41,22 @@ jobs:
# a v4 failure never fails the job (promoted to required at cutover, PR-5.1).
# Gated on the ingest-role ARN var (the assume-role input that MUST exist) so
# it no-ops until v4 infra is wired.
#
# ORDER MATTERS: "Install uv" runs BEFORE "Configure AWS credentials".
# configure-aws-credentials persists the assumed ingest-role (rds-db:connect
# only) as the job's ambient AWS creds; the uv setup compiles via sccache
# (S3-backed), so running it after the role switch fails with S3 AccessDenied.
# Installing uv first keeps sccache on the original S3-capable creds; the role
# is assumed immediately before the ingest, which needs only rds-db:connect.
- name: Install uv for v4 ingest
if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
uses: spiraldb/actions/.github/actions/setup-uv@a746510eafaa926484c354541cfc49b2ec06cc63 # 0.18.6
- name: Configure AWS credentials for v4 ingest (OIDC)
if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
uses: aws-actions/configure-aws-credentials@e7f100cf4c008499ea8adda475de1042d6975c7b # v6
with:
role-to-assume: ${{ vars.GH_BENCH_INGEST_ROLE_ARN }}
aws-region: ${{ vars.RDS_BENCH_REGION }}
# Install ONLY the uv binary (no `uv sync`): the ingest runs
# `uv run --no-project --with`, which needs just the binary, not a workspace
# build. spiraldb's setup-uv ran a full `uv sync` that built vortex-python via
# sccache->S3 and failed under the ingest-role creds (which lack S3) -- pure
# waste, since the ingest never used the synced workspace.
- name: Install uv for v4 ingest
if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
- name: Ingest commit metadata to v4 Postgres (best-effort)
if: vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
Expand Down
20 changes: 9 additions & 11 deletions .github/workflows/sql-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,24 +689,22 @@ jobs:
# input that MUST exist for OIDC to succeed; it no-ops until v4 infra is wired), and
# every step is continue-on-error. post-ingest.py mints the RDS IAM token (boto3) from
# the assumed GitHubBenchmarkIngestRole; sslmode=verify-full validates the cert.
#
# ORDER MATTERS: "Install uv" runs BEFORE "Configure AWS credentials".
# configure-aws-credentials persists the assumed ingest-role (rds-db:connect
# only) as the job's ambient AWS creds; the uv setup compiles via sccache
# (S3-backed), so running it after the role switch fails with S3 AccessDenied.
# Installing uv first keeps sccache on the original S3-capable creds; the role
# is assumed immediately before the ingest, which needs only rds-db:connect.
- name: Install uv for v4 ingest
if: inputs.mode == 'develop' && vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
uses: spiraldb/actions/.github/actions/setup-uv@a746510eafaa926484c354541cfc49b2ec06cc63 # 0.18.6
- name: Configure AWS credentials for v4 ingest (OIDC)
if: inputs.mode == 'develop' && vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
uses: aws-actions/configure-aws-credentials@e7f100cf4c008499ea8adda475de1042d6975c7b # v6
with:
role-to-assume: ${{ vars.GH_BENCH_INGEST_ROLE_ARN }}
aws-region: ${{ vars.RDS_BENCH_REGION }}
# Install ONLY the uv binary (no `uv sync`): the ingest runs
# `uv run --no-project --with`, which needs just the binary, not a workspace
# build. spiraldb's setup-uv ran a full `uv sync` that built vortex-python via
# sccache->S3 and failed under the ingest-role creds (which lack S3) -- pure
# waste, since the ingest never used the synced workspace.
- name: Install uv for v4 ingest
if: inputs.mode == 'develop' && vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
- name: Ingest results to v4 Postgres (best-effort)
if: inputs.mode == 'develop' && vars.GH_BENCH_INGEST_ROLE_ARN != ''
continue-on-error: true
Expand Down
Loading