Skip to content

VortexSession API cleanup pass#8503

Open
AdamGS wants to merge 1 commit into
developfrom
adamg/session-new-api-pass
Open

VortexSession API cleanup pass#8503
AdamGS wants to merge 1 commit into
developfrom
adamg/session-new-api-pass

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR makes the final pass to make the VortexSession immutable, removing the to_builder function and trying to clear up all call sites.

I've also tried to find all docs referencing it, but the change touches so many places I might've missed something.

One big change here is changing array_session (which I think I introduced?) to default_session_builder

@AdamGS AdamGS changed the title pass Another pass to clean up old session APIs Jun 19, 2026
@AdamGS AdamGS added the changelog/chore A trivial change label Jun 19, 2026
@tl-dr-review tl-dr-review Bot added the tldr label Jun 19, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 271 untouched benchmarks
⏩ 1319 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation slice_empty_vortex 310 ns 368.3 ns -15.84%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/session-new-api-pass (70756d4) with develop (b4c85b6)

Open in CodSpeed

Footnotes

  1. 1319 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@tl-dr-review tl-dr-review Bot added tldr and removed tldr labels Jun 19, 2026
@AdamGS AdamGS force-pushed the adamg/session-new-api-pass branch from d86eea0 to 8cce41b Compare June 19, 2026 12:44
@AdamGS AdamGS force-pushed the adamg/session-new-api-pass branch 3 times, most recently from fe9d7d4 to ff676f7 Compare June 23, 2026 17:57
@AdamGS AdamGS force-pushed the adamg/session-new-api-pass branch from 5682184 to ab39ca5 Compare June 23, 2026 18:48
@AdamGS AdamGS force-pushed the adamg/session-new-api-pass branch from ab39ca5 to c3bd22c Compare June 24, 2026 08:56
@AdamGS AdamGS requested review from gatesn and robert3005 and removed request for robert3005 June 24, 2026 08:57
@AdamGS AdamGS changed the title Another pass to clean up old session APIs VortexSession API cleanup pass Jun 24, 2026
@AdamGS AdamGS force-pushed the adamg/session-new-api-pass branch from 7dd3548 to 7d09a33 Compare June 24, 2026 09:59
@AdamGS AdamGS marked this pull request as ready for review June 24, 2026 10:23
@AdamGS AdamGS requested a review from a team June 24, 2026 10:23
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@robert3005

Copy link
Copy Markdown
Contributor

We want shorthand methods for the builders as well so we don't have to use get_mut::<T>()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change tldr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants