Widen VarBinBuilder offets during FSST compress#7853
Open
connortsui20 wants to merge 1 commit intodevelopfrom
Open
Widen VarBinBuilder offets during FSST compress#7853connortsui20 wants to merge 1 commit intodevelopfrom
VarBinBuilder offets during FSST compress#7853connortsui20 wants to merge 1 commit intodevelopfrom
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
VarBinBuilder offets during FSST compress
joseph-isaacs
requested changes
May 8, 2026
Contributor
joseph-isaacs
left a comment
There was a problem hiding this comment.
please have the test run in ci. what is the problem with doing it?
Merging this PR will degrade performance by 15.69%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | take_map[(0.1, 0.5)] |
1,111.5 µs | 989.4 µs | +12.34% |
| ⚡ | Simulation | take_map[(0.1, 1.0)] |
1.8 ms | 1.6 ms | +11.81% |
| ❌ | Simulation | eq_pushdown_high_match |
1.1 ms | 1.3 ms | -14.44% |
| ❌ | Simulation | eq_pushdown_low_match |
982.4 µs | 1,165.3 µs | -15.69% |
Comparing ct/offsets-i64 (0275c57) with develop (ff12040)
Contributor
Author
|
Oh I forgot about test with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #7833
I don't think that a more complicated solution here makes a lot of sense. We narrow these offsets is the compressor anyways, so there is no reason to do something more complicated than this.
Additionally adds the logic for comparing with arrow large binary arrays that was missing before.
To be honest, I feel like it doesn't really make any sense to allow the user to specify what the offsets and sizes types should be at all, I think we can have the builder always use the 64-bit types because we know that they will be compressed by the compressor anyways.
Testing
Adds some regression tests. I've ignored the big test because it allocates too much memory.
You can run the ignored test with: