Skip to content

fix[bitpacked]: slice patches in execute method (not reduce).#7839

Merged
joseph-isaacs merged 9 commits intodevelopfrom
ji/fix-up-slice-bp-reduce
May 8, 2026
Merged

fix[bitpacked]: slice patches in execute method (not reduce).#7839
joseph-isaacs merged 9 commits intodevelopfrom
ji/fix-up-slice-bp-reduce

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

Problem: BitPacked's SliceReduce implementation called patches.slice(), which reads buffers (search_index does binary search on buffer data, execute_scalar executes on chunk offsets). This violates the SliceReduce contract that requires metadata-only operations.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Comment thread encodings/fastlanes/src/bitpacking/compute/slice.rs Outdated
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) May 8, 2026 10:04
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 8, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 1208 untouched benchmarks


Comparing ji/fix-up-slice-bp-reduce (5dbe242) with develop (fb2feb2)

Open in CodSpeed

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the changelog/fix A bug fix label May 8, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit d0d9a8b into develop May 8, 2026
66 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/fix-up-slice-bp-reduce branch May 8, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants