Skip to content

Cache min/max indices in patches #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palaska wants to merge 12 commits into
base: develop
Choose a base branch
from
+184 −52

Merge branch 'bp/minmax-index' of github.com:vortex-data/vortex into …

8bc3d8a
Select commit
Loading
Failed to load commit list.
Open

Cache min/max indices in patches #7753

Merge branch 'bp/minmax-index' of github.com:vortex-data/vortex into …
8bc3d8a
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed May 6, 2026 in 0s

Performance Regression: -31.73%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 16 improved benchmarks
❌ 71 regressed benchmarks
✅ 1119 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime cuda/bitpacked_u8/unpack/3bw[100M] 352.3 µs 298.6 µs +17.96%
❌ Simulation chunked_dict_primitive_canonical_into[f32, (1000, 100, 100)] 686.1 µs 766.3 µs -10.46%
❌ Simulation chunked_dict_primitive_canonical_into[u32, (1000, 100, 100)] 685.8 µs 764.6 µs -10.31%
❌ Simulation chunked_dict_primitive_canonical_into[u32, (1000, 10, 100)] 670.5 µs 749.3 µs -10.52%
❌ Simulation chunked_dict_primitive_canonical_into[u32, (1000, 100, 10)] 87.4 µs 97.2 µs -10.08%
❌ Simulation chunked_dict_primitive_canonical_into[f32, (1000, 10, 100)] 670.4 µs 750.6 µs -10.69%
❌ Simulation chunked_dict_primitive_into_canonical[f32, (1000, 10, 100)] 727.7 µs 808.6 µs -10%
❌ Simulation chunked_dict_primitive_into_canonical[u32, (1000, 100, 10)] 97.6 µs 108.7 µs -10.22%
❌ Simulation decode_primitives[f32, (1000, 2)] 17 µs 19.8 µs -14.19%
❌ Simulation decode_primitives[f32, (1000, 32)] 17.1 µs 19.3 µs -11.85%
❌ Simulation decode_primitives[f32, (1000, 4)] 17 µs 19.9 µs -14.71%
❌ Simulation decode_primitives[f32, (1000, 512)] 18.3 µs 20.9 µs -12.34%
❌ Simulation decode_primitives[f32, (1000, 8)] 17 µs 19.3 µs -11.75%
❌ Simulation decode_primitives[i64, (1000, 2)] 19.3 µs 22.3 µs -13.65%
❌ Simulation decode_primitives[i64, (1000, 4)] 19.3 µs 22 µs -12.43%
❌ Simulation decode_primitives[i64, (1000, 512)] 21.4 µs 24.3 µs -11.91%
❌ Simulation decode_primitives[i64, (1000, 8)] 19.3 µs 22 µs -11.94%
❌ Simulation decode_primitives[u8, (1000, 2)] 16.4 µs 18.8 µs -12.67%
❌ Simulation decode_primitives[u8, (1000, 32)] 16 µs 18.4 µs -13.09%
❌ Simulation decode_primitives[u8, (1000, 4)] 16 µs 18.4 µs -13.25%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Comparing bp/minmax-index (8bc3d8a) with develop (f307edc)

Open in CodSpeed
View more details on CodSpeed HQ