Skip to content

remove duckdb object cache integration#6848

Draft
myrrc wants to merge 1 commit intodevelopfrom
myrrc/rm-duckdb-object-cache
Draft

remove duckdb object cache integration#6848
myrrc wants to merge 1 commit intodevelopfrom
myrrc/rm-duckdb-object-cache

Conversation

@myrrc
Copy link
Contributor

@myrrc myrrc commented Mar 9, 2026

#6652 makes Duckdb use
Vortex cache instead of its own cache. Object cache in Duckdb isn't used
anywhere except for tests.

@myrrc myrrc added changelog/chore A trivial change ext/duckdb Relates to the DuckDB integration labels Mar 9, 2026
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/rm-duckdb-object-cache branch from 51229e9 to 949a4ee Compare March 9, 2026 11:16
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 9, 2026

Merging this PR will improve performance by 26.44%

⚡ 5 improved benchmarks
✅ 995 untouched benchmarks
⏩ 1466 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation patched_take_10k_contiguous_patches 2.3 ms 2.1 ms +10.81%
Simulation patched_take_200k_dispersed 5.6 ms 4.7 ms +19.88%
Simulation patched_take_200k_first_chunk_only 5.4 ms 4.8 ms +11.99%
Simulation take_200k_dispersed 4.5 ms 3.6 ms +24.36%
Simulation take_200k_first_chunk_only 4.2 ms 3.3 ms +26.44%

Comparing myrrc/rm-duckdb-object-cache (949a4ee) with develop (dfe3699)

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc myrrc marked this pull request as draft March 9, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant