Skip to content

Public array modules#6834

Merged
gatesn merged 5 commits intodevelopfrom
ngates/array-modules
Mar 6, 2026
Merged

Public array modules#6834
gatesn merged 5 commits intodevelopfrom
ngates/array-modules

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Mar 6, 2026

We were running into naming conflicts by using pub use primitive::* etc for all arrays. This PR instead exports the modules as pub, and to minimize the user-facing break continues to explicitly re-export the FooArray and FooVTable for each array.

gatesn added 3 commits March 6, 2026 16:30
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from connortsui20 March 6, 2026 21:44
@gatesn gatesn added the changelog/break A breaking API change label Mar 6, 2026
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) March 6, 2026 21:48
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 6, 2026

Merging this PR will degrade performance by 11%

⚡ 3 improved benchmarks
❌ 2 regressed benchmarks
✅ 975 untouched benchmarks
🆕 20 new benchmarks
⏩ 1466 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.1)] 1,007.5 µs 898.8 µs +12.1%
Simulation take_map[(0.1, 1.0)] 4.2 ms 3.6 ms +17.59%
Simulation take_map[(0.1, 0.5)] 2.6 ms 2 ms +26.53%
🆕 Simulation sequence_decompress_u32 N/A 4.1 ms N/A
🆕 Simulation sequence_compress_u32 N/A 5.2 ms N/A
🆕 Simulation decompress_utf8[(10000, 1024)] N/A 112.5 µs N/A
🆕 Simulation decompress_utf8[(100000, 16)] N/A 1.2 ms N/A
🆕 Simulation decompress_utf8[(10000, 16)] N/A 135.9 µs N/A
🆕 Simulation decompress_utf8[(10000, 4)] N/A 209.8 µs N/A
🆕 Simulation decompress_utf8[(10000, 256)] N/A 113.2 µs N/A
🆕 Simulation decompress_utf8[(1000000, 256)] N/A 9.4 ms N/A
🆕 Simulation decompress_utf8[(100000, 4)] N/A 1.9 ms N/A
🆕 Simulation decompress_utf8[(1000000, 4)] N/A 19 ms N/A
🆕 Simulation decompress_utf8[(100000, 256)] N/A 958.2 µs N/A
🆕 Simulation decompress_utf8[(1000000, 1024)] N/A 9.3 ms N/A
🆕 Simulation decompress_utf8[(100000, 1024)] N/A 946.8 µs N/A
🆕 Simulation decompress_utf8[(1000000, 16)] N/A 11.7 ms N/A
🆕 Simulation decompress_utf8[(1000000, 4096)] N/A 9.3 ms N/A
🆕 Simulation decompress_utf8[(1000000, 8192)] N/A 9.3 ms N/A
🆕 Simulation decompress_utf8[(100000, 4096)] N/A 944.7 µs N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ngates/array-modules (cbaffbf) with develop (5d6a3c8)2

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (edec459) during the generation of this report, so 5d6a3c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Contributor

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 6a34208 into develop Mar 6, 2026
50 checks passed
@gatesn gatesn deleted the ngates/array-modules branch March 6, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants