Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
| elements.len() | ||
| ); | ||
|
|
||
| let mut bytes = [0u8; UUID_BYTE_LEN]; |
| /// Accepts any standard UUID string format (hyphenated, simple, braced, URN). Invalid strings | ||
| /// cause an error. | ||
| #[derive(Clone)] | ||
| pub struct UuidFromString; |
There was a problem hiding this comment.
Hmm, I really do think we should just go directly to pluggable casting. CC @joseph-isaacs
Merging this PR will degrade performance by 11%
Performance Changes
Comparing Footnotes
|
|
Ok so I'm going to remove the |
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
127212c to
9242442
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Summary
Adds a UUID extension type to Vortex over a
FixedSizeList<u8, 16>. There isn't much functionality implemented on top of this, and there is no exporter to Arrow's UUID canonical extension type. All of the logic is delegated to the Rustuuidcrate.There is still a question of if we want to bring in
FixedSizeBinaryinstead of doing this.Testing
Some small basic tests. They serve mostly as example code on how to work with Uuid extension arrays in general.
Open Questions
FixedSizeBinaryinstead here? Why does this not suffice?unpack_nativeis terrible because we still do not haveScalarValue::Array(seeScalarValue::Array#6717)vortex.uuidsince we know we might change the storage type in the future?UuidFromStringshould really be implemented under theCastexpression, but we do not have a system yet for pluggable expressions so it is not entirely clear how we would do that.UuidToStringis an easy next one, what else is there?