perf[runend]: run_end_bool decompress#6229
Merged
robert3005 merged 11 commits intodevelopfrom Mar 11, 2026
Merged
Conversation
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
do not merge
Merging this PR will degrade performance by 12.26%
Performance Changes
Comparing 
Footnotes
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
joseph-isaacs
added
changelog/performance
github-actions
bot
removed
the
action/benchmark
robert3005
reviewed
Jan 30, 2026
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
Love me some prefilling
joseph-isaacs
changed the title
robert3005
reviewed
Feb 2, 2026
Contributor
|
This PR has been marked as stale because it has been open for 30 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
joseph-isaacs
force-pushed
the
ji/run-end-perf-bool
branch
from
ab1cffe to
3222cdc
Compare
robert3005
requested changes
Mar 10, 2026
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
I think there's a bit too much llm leftover code here
… and fill_bits - Add `fill_bits` free function to vortex-buffer for efficient bit-range filling on raw `&mut [u8]` slices - Add `BitBufferMut::fill_range` method that delegates to `fill_bits` - Refactor `append_n` to delegate to `fill_range`, eliminating duplication - Replace private `fill_bits_true`/`fill_bits_false`/`flip_bits` helpers in decompress_bool.rs with `BitBufferMut::fill_range` - Simplify few-runs nullable path to use `append_n` directly - Replace `prefill_buffer` helper with `BitBufferMut::full` - Remove unused re-export of `runend_decode_bools` from compress.rs - Remove baseline benchmark code (decode_bool_nullable_develop) - Delete PERF_NOTES.md - Fix clippy is_multiple_of warnings in benchmarks Signed-off-by: Joseph Isaacs <joe@spiraldb.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
robert3005
reviewed
Mar 10, 2026
joseph-isaacs
removed
the
do not merge
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
force-pushed
the
ji/run-end-perf-bool
branch
from
cad9f85 to
6e8ef5c
Compare
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
robert3005
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
speed up runend bool decompress