Closed
Conversation
We proved the idea out with ScalarFns, but realised we can minimize the diff for end-users if we actually just re-purpose an expression to == a scalar function. It pretty much was already anyway. This PR is a step on the way to having Expression -> Array be a constant-time operation, with actual compute deferred until we execute the array tree. # Breaking Changes * Expression VTable changes * `Instance` renamed to `Options` to make the purpose more obvious * Added an `Arity` function to replace `validate`, since the only possible validation in the absence of types is arity based anyway. * Added an optional `execute` function that will replace `evaluate` in the future. * Removed `fmt_data` in favor of requiring a Display bound on the associated Options type. * `return_dtype` takes a `ReturnDTypeCtx` to avoid eagerly computing child dtypes. * Removed ExpressionView in favor of returning the options from `Expression::as_` and `Expression::as_opt`. Other changes that I don't expect will impact users: * Moved `is_null_sensitive` and `child_name` from `Expression`, to `ExpressionSignature` * Moved `Expression::serialize_metadata()` to `Expression::options().serialize()` * Removed ExprOptimizer, in favor of `VTable::simplify`. Any more complex optimizations can be implemented in future over the Array tree prior to execution. --------- Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
…operators Merge develop
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
This is a WIP PR to flesh out the code path that uses vector execution rather than array compute functions. --------- Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
* Fixes a few bugs * Adds missing Scalar::from_vector_scalar conversion * Adds a couple of push-down rules, fixes optimizer to run them bottom up in the same pass * Adds filter push-down, albeit without any cost estimates. --------- Signed-off-by: Nicholas Gates <nick@nickgates.com> Signed-off-by: Siddharth Kumar <SiddharthKumarGulia@proton.me> Co-authored-by: Alfonso Subiotto Marqués <alfonso.subiotto@polarsignals.com> Co-authored-by: Baris Palaska <barispalaska@gmail.com> Co-authored-by: sherlockbeard <sidkumargulia@gmail.com> Co-authored-by: Connor Tsui <87130162+connortsui20@users.noreply.github.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Contributor
|
This PR has been marked as stale because it has been open for 30 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
github-actions
Bot
added
stale
Contributor
|
This PR has been marked as stale because it has been open for 30 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
Contributor
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.