Skip to content

fix(filters): inline FiltersButton props to avoid nuxt 4.4.6 SFC regression#57

Closed
benjamincanac wants to merge 1 commit into
mainfrom
fix/nuxt-4.4.6-sfc-extends-regression
Closed

fix(filters): inline FiltersButton props to avoid nuxt 4.4.6 SFC regression#57
benjamincanac wants to merge 1 commit into
mainfrom
fix/nuxt-4.4.6-sfc-extends-regression

Conversation

@benjamincanac
Copy link
Copy Markdown
Contributor

Summary

Follow-up to #56. After fixing ChatPrompt, renovate's nuxt 4.4.6 bump (#54) still fails on Vercel, this time on FiltersButton.vue:

```
[vite:vue] [@vue/compiler-sfc] Failed to resolve import source "vue-chrts/types".
.nuxt/types/imports.d.ts:515
export type { BulletLegendItemInterface, ... } from 'vue-chrts/types'
file: app/components/filters/FiltersButton.vue
```

Same regression class: nuxt 4.4.6's bundled @vue/compiler-sfc follows external type chains more aggressively when resolving defineProps<ExternalType & {...}> / defineProps<Pick<ExternalType, ...> & {...}>, tripping over nuxt-charts's auto-imported vue-chrts/types source (which has no runtime export).

Switch FiltersButton to inline props with indexed-access types (ButtonProps['color'] etc.) — keeps type-safety without forcing the SFC compiler to flatten ButtonProps.

Reproduced locally on nuxt@4.4.6; with this change pnpm build + pnpm typecheck are both green.

Test plan

  • Reproduced original failure locally with pnpm add nuxt@4.4.6.
  • pnpm build and pnpm typecheck pass with the fix on nuxt@4.4.6.
  • CI green on this PR.
  • After merge, renovate's PR chore(deps): update dependency nuxt to ^4.4.6 #54 rebases and Vercel build passes on nuxt@4.4.6.

🤖 Generated with Claude Code

Same nuxt 4.4.6 SFC compiler regression that hit ChatPrompt: using
`Pick<ButtonProps, ...> & { ... }` in defineProps trips
@vue/compiler-sfc's "Failed to resolve import source 'vue-chrts/types'"
when it follows the type chain through Nuxt's generated imports.d.ts.

Switch to inline props with indexed-access types (`ButtonProps['color']`
etc.), which keeps type-safety without forcing the SFC compiler to flatten
the base type. Verified locally with nuxt@4.4.6: pnpm build + pnpm typecheck
both green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Warning

Rate limit exceeded

@benjamincanac has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 6 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b621eebd-fa0b-4252-ba88-b0c0543fdbca

📥 Commits

Reviewing files that changed from the base of the PR and between 022b375 and c737df4.

📒 Files selected for processing (1)
  • app/components/filters/FiltersButton.vue
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/nuxt-4.4.6-sfc-extends-regression

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant