Add Claude Desktop Memory Integration Example Under examples/Claude-Desktop#2389
Add Claude Desktop Memory Integration Example Under examples/Claude-Desktop#2389itzsamehfawzi wants to merge 1 commit into
Conversation
|
Hi @qin-ctx, Please let me know if you’d like the folder renamed, reorganized, or split into smaller components. Happy to adjust anything. Thanks for the guidance. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Thanks for the automated analysis. Regarding the “Multiple PR themes” note: Why the PR contains multiple file groups
server/openviking-mcp.py server/openviking-watchdog.py These files work together to: expose OpenViking memory operations via MCP maintain a persistent background process auto‑restart on failure provide a stable bridge for Claude Desktop
hooks/ov-recall.js hooks/ov-capture.js These scripts integrate with Claude Desktop to: recall memory before each coding session capture new memory after each session pass data through the MCP bridge Why they belong in a single PR “How to connect Claude Desktop to OpenViking’s memory engine end‑to‑end.” Splitting these into separate PRs would break the example and make it incomplete. Summary Each group supports a different layer of the integration (MCP bridge vs. Claude hooks). All files are isolated under examples/Claude-Desktop/ and do not affect core code. Happy to reorganize or split folders if you prefer a different structure. |
|
Thanks for putting this together — there's clearly a lot of care here, and a few things are genuinely well done: the REST endpoints all line up with the current server API, the error handling degrades gracefully when the server is down, and the docs/troubleshooting/verification work shows real effort. 🙏 That said, I think the PR needs a significant rework before it can land, mostly for structural reasons rather than code-quality ones. Sharing the main points so we can find the right shape together: 1. Scope overlaps with what we already ship. OpenViking already provides:
2. The title says "Claude Desktop," but ~half the code is Claude Code. 3. Repo hygiene. The PR vendors an entire standalone-repo scaffold into 4. Configuration is hardcoded. 5. Platform coupling. The ~7 PowerShell scripts (watchdog, Task Scheduler registration, health alerts) and the Windows 11 / Python 3.13 / Node 20 pinning make this hard for the project to maintain or test cross-platform. If the watchdog/scheduler pieces are valuable, they'd fit better as an optional section in the troubleshooting docs rather than as core example code. A couple of smaller correctness notes for whenever the recall path gets revisited: the single global If you'd like to keep contributing here, the most useful direction would probably be a minimal, config-driven, cross-platform Claude Desktop MCP example — or, given we already expose MCP, a short doc/guide on pointing Claude Desktop at the existing server. Happy to help scope that down if you're up for it. Thanks again for the contribution! 🙌 |
This PR adds a full Claude Desktop memory‑integration example under examples/Claude-Desktop/, following the project’s contribution guidelines and the maintainer’s request to place Claude‑related examples inside the examples directory rather than the main README.
What’s included
A complete working integration between OpenViking and Claude Desktop
Automatic memory recall before Claude Code prompts
Automatic memory extraction and commit after each session
Windows‑native watchdog for self‑healing restarts
Windows Task Scheduler automation (autosave + health checks)
Embedding selector with Ollama‑first + Jina fallback
A 26‑point verification script to validate the integration
A dedicated Markdown example file documenting usage and setup
Why this belongs in examples/Claude-Desktop/
This integration is a standalone example demonstrating how to connect Claude Desktop to OpenViking’s memory engine.
It does not modify the core library and fits the structure used for other Claude‑related examples.
Folder structure
Code
examples/
Claude-Desktop/
openviking-claude-desktop.md
Notes
No changes were made to the main README.
All files are isolated to the example folder.
The branch contains only documentation + example code, no core logic changes.
Let me know if you prefer a different folder name or want the example split into submodules.