feat(fspy): add no-std Windows module lookup - #656
Merged
Conversation
wan9chi
force-pushed
the
agent/windows-nostd-module-lookup
branch
from
August 12, 2026 16:27
3c2fba3 to
ffbefa9
Compare
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
agent/windows-nostd-module-lookup
branch
from
August 13, 2026 00:34
ffbefa9 to
8719c56
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
wan9chi
force-pushed
the
agent/windows-nostd-module-lookup
branch
from
August 13, 2026 00:34
8719c56 to
3d8e4d6
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Windows preload initializes under the loader lock, where loading another DLL can deadlock or run unsafe initialization. Extend
fspy_nostdto Windows with unit-generic C strings, aWideCStralias, static wide literals, andget_module_name, which queries an already-loaded module throughGetModuleHandleW.Migrate
AttachContextaway fromLoadLibraryA. KernelBase remains optional, while missing Kernel32 or NTDLL modules are reported to the caller.