Skip to content

test(snapshots): pin dev_engines_runtime_pnpm11 to the seeded default Node version #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wan9chi merged 1 commit into from
Aug 10, 2026
+7 −3
Merged

test(snapshots): pin dev_engines_runtime_pnpm11 to the seeded default Node version #2390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/dev_engines_runtime_pnpm11/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"devEngines": {
"runtime": {
"name": "node",
"version": "22.22.2"
"version": "22.18.0"
}
},
"packageManager": "pnpm@11.0.6"
Expand Down
6 changes: 5 additions & 1 deletion ...s/vp_cli_snapshots/tests/cli_snapshots/fixtures/dev_engines_runtime_pnpm11/snapshots.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
[[case]]
name = "dev_engines_runtime_pnpm11"
vp = "global"
# The devEngines pin must stay on vp's default Node.js version: the CI seed
# only carries the default, and any other pin makes this step download a
# runtime from nodejs.org inside its 60s budget, which times out when the
# Windows runner's connection stalls.
steps = [
{ argv = ["vp", "dlx", "-s", "print-current-version"], comment = "should print Node.js version 22.22.2 from devEngines.runtime", continue-on-failure = true },
{ argv = ["vp", "dlx", "-s", "print-current-version"], comment = "should print Node.js version 22.18.0 from devEngines.runtime", continue-on-failure = true },
]
2 changes: 1 addition & 1 deletion ...ots/fixtures/dev_engines_runtime_pnpm11/snapshots/dev_engines_runtime_pnpm11.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## `vp dlx -s print-current-version`

should print Node.js version 22.22.2 from devEngines.runtime
should print Node.js version 22.18.0 from devEngines.runtime

```
<version>
Expand Down
Loading