fix(core): rewrite BUNDLED_DEV_CLIENT_ENTRY for packaged layout - #2384
Open
lofcz wants to merge 1 commit into
Open
fix(core): rewrite BUNDLED_DEV_CLIENT_ENTRY for packaged layout#2384lofcz wants to merge 1 commit into
lofcz wants to merge 1 commit into
Conversation
experimental.bundledDev reads bundledDevClient.mjs via fs, which bypasses the package exports remap of dist/client/* to dist/vite/client/*. Rewrite the constant alongside CLIENT_ENTRY and ENV_ENTRY so vp dev can start.
✅ Deploy Preview for viteplus-preview canceled.
|
Member
|
@lofcz Thanks for the fix commit. Could you please submit an issue first to describe the current problem? |
Author
|
Experimental dev bundling available in vite 8.1+ is broken due to the path being trivially wrong. With this fix, the feature can be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rewrite-static-pathsalready remapsCLIENT_ENTRYandENV_ENTRYtodist/vite/client/..., butBUNDLED_DEV_CLIENT_ENTRYwas left pointing atdist/client/bundledDevClient.mjs.experimental.bundledDev: truethen fails withENOENTbecause Vite reads that path withfs.readFileSync, which does not honor the./dist/client/*→./dist/vite/client/*package export.BUNDLED_DEV_CLIENT_ENTRYto match the packaged layout (and document it inBUNDLING.md).