Skip to content

fix(test): stabilize flaky network-dependent tests#1923

Draft
fengmk2 wants to merge 1 commit into
mainfrom
codex/stabilize-flaky-tests
Draft

fix(test): stabilize flaky network-dependent tests#1923
fengmk2 wants to merge 1 commit into
mainfrom
codex/stabilize-flaky-tests

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

  • retry the complete HTTP body and JSON decode operation for npm metadata and the Node.js version index
  • keep version classification and package-manager priority unit tests deterministic instead of reaching live registries
  • allow the first Vite config evaluation more time on slow Windows CI workers

Validation

  • cargo fmt --all -- --check
  • cargo clippy -p vite_install -p vite_js_runtime -p vite_global_cli --all-targets -- -D warnings
  • env -u NODE_OPTIONS RUST_MIN_STACK=8388608 cargo test -p vite_install -p vite_js_runtime --locked
  • cargo test -p vite_global_cli test_classify_version --locked
  • git diff --check

The focused TypeScript test requires generated Vite/Core/CLI build artifacts that are not present in a fresh worktree; CI will run it after the normal build setup.

@fengmk2 fengmk2 self-assigned this Jun 23, 2026
@netlify

netlify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit bffcc19
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a3a7d323112f80008d7e2ae

@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests labels Jun 23, 2026
@fengmk2

fengmk2 commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: bffcc19d27

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant