-
Notifications
You must be signed in to change notification settings - Fork 215
feat: passthrough fallback for vpr/vp i on low Node (#1909 #1916) #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
l246804
wants to merge
19
commits into
voidzero-dev:main
Choose a base branch
from
l246804:feat/low-node-passthrough
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
36158f0
docs: add low-Node passthrough design for #1909 #1916
728546b
docs: add low-Node passthrough implementation plan
036f6c8
docs: fix self-review contradictions in passthrough plan (clone, walk…
9e7ddfd
feat(vite_shared): add MIN_SUPPORTED_NODE passthrough threshold
3007ed7
docs: require reading AGENTS.md + ban bare cargo test in plan constra…
5f0ef67
fix(vite_shared): add node-semver dep + fix Version::parse Result mat…
fb18611
docs: add local env prerequisites (RUSTC_BOOTSTRAP, vite-task patch) …
1533d4e
feat(vite_install): add PackageManagerBuilder::detect_only for passth…
325a643
feat(vite_global_cli): add passthrough eligibility + notice helpers
582ff13
docs: fix vite_global_cli test cmd (--bin vp not --lib) + note pre-ex…
070ffb4
refactor(vite_pm_cli): extract dispatch_with_pm and *_with_pm handlers
8aeaac3
feat(vite_global_cli): implement passthrough execute via detect_only …
2a5979e
fix: address Task 4a/4b review findings
7aed1ca
feat(vite_global_cli): add passthrough precheck in run_command_with_o…
5d290e8
test(vite_global_cli): add passthrough e2e + snap fixture
aa9d941
fix: add passthrough precheck to vpr shim path
6081e10
chore: remove design docs from PR (not intended for merge)
ac565de
chore: clean up dead_code comments in passthrough module
5cfcafa
Merge branch 'main' into feat/low-node-passthrough
l246804 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This returns the raw version source, so supported inputs like
.node-versioncontaining18/18.20orengines.node: "<20"are passed directly tois_node_below_min, fail semver parsing, and skip passthrough. Those projects then continue to the old JS delegation path even though the runtime resolver would choose a Node version below 20.19.0. Compare against the resolved exact Node version instead of the raw source string.Useful? React with 👍 / 👎.