ci: replace zizmor and cargo-deny with oxc-project/security-action#1635
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1a81593cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Boshen
force-pushed
the
ci/security-action
branch
from
c1a8159 to
79e8f68
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79e8f681fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengmk2
approved these changes
May 20, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Boshen
force-pushed
the
ci/security-action
branch
from
fd4262e to
3aa21dc
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3aa21dc7b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
ci fix in #1645 |
fengmk2
added a commit
that referenced
this pull request
May 20, 2026
…lake The command-upgrade-check snap test was failing on PR CIs running after v0.1.22 shipped because dev's package.json version (0.1.22) now equals npm latest (0.1.22), so `vp upgrade --check` takes the "Already up to date" branch instead of the recorded "Update available" output. Query the `alpha` dist-tag instead. Alpha is always a different version from latest (currently 0.1.21-alpha.7), so the "Update available" branch is always taken and the snapshot is stable across release cycles. The semver normalization in the snap-test framework masks the actual version numbers, so the body of snap.txt is unchanged. Same root cause as the cli-e2e-test upgrade-bash fix in this PR; the snap test surfaced on PR #1635 first because that PR also triggered CI after the release.
2 tasks
fengmk2
added a commit
that referenced
this pull request
May 20, 2026
## Summary Right after a release commit lands on main, the dev build's `package.json` version equals npm latest. Two CI checks were hard-coded to assert outputs that only happen when those versions differ, so they fail on every release-day PR run. **CLI E2E `Test upgrade (bash/pwsh/cmd)`** (ci.yml) — asserted `UPDATED_VERSION != INITIAL_VERSION` after `vp upgrade --force`. When dev == latest, the upgrade runs end-to-end but the version is unchanged. - Fix: assert on the `current` install dir basename (`local-dev-<ts>/` → `<version>/`) instead. The dir flip proves the download/extract/swap and rollback flows ran. Node's `fs.realpathSync` resolves both Unix symlinks and Windows junctions, so all three shells share the same helper. **Snap test `command-upgrade-check`** (`packages/cli/snap-tests-global/command-upgrade-check/`) — recorded the "Update available" output of `vp upgrade --check`. When dev == latest, the actual output is "Already up to date". - Fix: query the `alpha` dist-tag instead. Alpha is always a different version from latest (currently `0.1.21-alpha.7`), so the "Update available" branch is always taken. Semver normalization masks the actual version, so the snap body is unchanged. ## Failure examples - Upgrade test: https://github.com/voidzero-dev/vite-plus/actions/runs/26112690623/job/76915605617 - Snap test: https://github.com/voidzero-dev/vite-plus/actions/runs/26148842387/job/76910949450 (also blocks #1635) ## Test plan - [ ] CI passes on this PR. - [ ] After next release, both checks still pass on the post-release-day merge-to-main run. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes only affect CI assertions and snapshot test inputs, not production code. Main risk is masking a real regression if install directory swapping semantics change. > > **Overview** > Makes the CI `vp upgrade` E2E checks resilient to release-day runs by **asserting on the `.vite-plus/current` install directory target** (via `fs.realpathSync`) instead of comparing CLI versions, across bash/pwsh/cmd. > > Stabilizes the `command-upgrade-check` snapshot by running `vp upgrade --check` against the `alpha` dist-tag so the *"Update available"* branch is consistently exercised. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e4556ae. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/zizmor.ymland.github/workflows/deny.ymlworkflowsdeny.tomlconfiguration.github/workflows/security.ymlusingoxc-project/security-action@v1.0.5🤖 Generated with Claude Code