chore: fix bootstrap cli on Windows by fengmk2 · Pull Request #1583 · voidzero-dev/vite-plus

fengmk2 · 2026-05-15T07:03:12Z

Summary

import Vite's Rolldown config directly from the real source path so Windows checkouts do not try to parse symlink placeholder text
fall back from pwsh to Windows PowerShell when launching install.ps1
make local-dev cleanup handle Windows junctions and locked vp.exe installs gracefully

Verification

pnpm bootstrap-cli
pnpm install-global-cli
vp --version

Note

Medium Risk
Moderate risk because it changes the Windows install/bootstrap path and cleanup behavior for global CLI installs, which could break developer setup on Windows if edge cases are missed; runtime product code is not affected.

Overview
Fixes Windows bootstrap issues by removing symlink-placeholder TypeScript configs in packages/core and having packages/core/build.ts import Vite’s rolldown.config directly from the upstream vite/ submodule path.

Improves install-global-cli on Windows by falling back from pwsh to Windows PowerShell, and by making local-dev install cleanup skip the active current install, correctly delete junction/symlink trees, and tolerate locked vp.exe binaries.

Updates developer tooling to run Rust tests per-crate (including vite-plus-cli) on both Unix and Windows, and trims TS/lint excludes now that the placeholder symlink files are gone.

^{Reviewed by Cursor Bugbot for commit 39ebb62. Configure here.}

netlify · 2026-05-15T07:03:18Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`39ebb62`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a0aa9aebe225e000804a438

fengmk2 · 2026-05-16T06:39:31Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 906838b. Configure here.}

fengmk2 · 2026-05-18T03:42:33Z

@cursor review

fengmk2 · 2026-05-18T05:41:22Z

@cursor review

After routing build.ts to import vite/packages/vite/rolldown.config.js directly, the two symlinks under packages/core (rollupLicensePlugin.ts, vite-rolldown.config.ts) are no longer referenced by any build code. Drop them along with the now-dead ignore/exclude entries in vite.config.ts and tsconfig.json.

fengmk2 · 2026-05-18T05:57:10Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 39ebb62. Configure here.}

@liangmiQwQ

Release vite-plus v0.1.22: Security Patch, Parallel Global Install & Scaffold Polish A critical Vitest browser-mode security fix, parallel `vp add -g` installs, a built-in oxlint rule to prefer `vite-plus` imports, and a new `--git` switch for `vp create`. ### Highlights - **Security**: bundled `vitest` bumped to `4.1.6` to address [GHSA-2h32-95rg-cppp](GHSA-2h32-95rg-cppp) (Critical, CVSS 9.6), an XSS to RCE chain via the `otelCarrier` query parameter in Vitest browser mode ([#1633](#1633)) - **Parallel global install**: `vp add/install/update -g` now installs packages concurrently with a progress bar and a `--concurrency` flag (default 5) ([#1597](#1597)) - **Prefer vite-plus imports**: new bundled oxlint rule rewrites `vite`/`vitest` imports to `vite-plus`, enabled by default in generated and migrated `lint` configs ([#1408](#1408)) - **Git init on scaffold**: `vp create` learns `--git`/`--no-git` (interactive prompt; auto-commits "Initial commit from Vite+") ([#1484](#1484)) ### Features - Spawn npm for global installation in parallel with a progress bar and a `--concurrency` option ([#1597](#1597)), by @liangmiQwQ - Add bundled oxlint rule to prefer `vite-plus` imports over `vite`/`vitest` ([#1408](#1408)), by @Han5991 - `vp create`: initialize a git repository and create an initial commit on scaffold ([#1484](#1484)), by @ryohidaka - `vp create`: rename underscore-prefixed files (`_gitignore`, `_npmrc`, `_yarnrc.yml`) to dotfiles for `@org/create` bundled templates ([#1574](#1574)), by @jong-kyung - Add `VP_PR_VERSION` env var to install unreleased PR builds via pkg.pr.new ([#1578](#1578)), by @fengmk2 ### Fixes & Enhancements - Skip merging standalone `.oxfmtrc`/`.oxlintrc` config when the `fmt:`/`lint:` key is already declared in `vite.config.ts` (fixes duplicate-block regression in `vp create fate`) ([#1601](#1601)), by @fengmk2 - Suppress the `VITE+ - The Unified Toolchain for the Web` banner for `vp lint --lsp`, `vp fmt --lsp`, and `vp fmt --stdin-filepath` so stdout stays a pure LSP / formatter stream ([#1619](#1619)), by @fengmk2 - `vp create`: detect output directory when running in the current directory ([#1606](#1606)), by @jong-kyung - `vp update -g`: skip installs when the recorded global package version already matches the npm-resolved version, and tolerate string/array outputs from `npm view ... version --json` ([#1596](#1596)), by @leno23 - `vp create`: preserve single-segment project path in `updateWorkspaceConfig` ([#1582](#1582)), by @jong-kyung - `vp env use`: keep the change session-scoped on Windows ([#1577](#1577)), by @fengmk2 - `vp rebuild`: accept positional package names ([#1564](#1564)), by @fengmk2 - Adopt the new vite-task error formatter; errors now print as `error: <top-level>` plus `* <source>` chain lines, with bold-red highlight on a TTY ([vite-task#390](voidzero-dev/vite-task#390)), by @branchseer - vite-task: forward `LOCALAPPDATA` so Node's compile cache stays outside the workspace on Windows ([vite-task#389](voidzero-dev/vite-task#389)), by @branchseer - Bump vite-task to `c945cc0` ([#1628](#1628)), by @branchseer ### Refactor - Revert `vp pm plugin` command (per discussion in #1038) ([#1623](#1623)), by @jong-kyung ### Docs - Add `vitepress-plugin-llms` to the docs site so the published docs include LLM-friendly outputs (`/llms.txt`) ([#1625](#1625)), by @jong-kyung - Refresh home stats for oxlint, vite, and vitest ([#1512](#1512)), by @nozomee - Mention `vp env doctor` in agent instructions ([#1603](#1603)), by @leno23 ### Chore - Consolidate the upstream build chain into a single `pnpm build` script (justfile recipe now just calls `pnpm build`) ([#1626](#1626)), by @fengmk2 - Fix bootstrap-cli on Windows ([#1583](#1583)), by @fengmk2 - Refresh trusted stack stats ([#1573](#1573), [#1616](#1616)), by @voidzero-guard[bot] - Update GitHub Actions ([#1611](#1611), [#1612](#1612)), by @renovate[bot] - Address zizmor findings in composite actions and the release workflow; drop unused `actions-cool/issues-helper` ([#1630](#1630)), by @Boshen - Switch plain checkouts to `taiki-e/checkout-action` ([#1620](#1620)), by @Boshen - Switch release to a version-bump PR + push trigger flow ([#1575](#1575)), by @Boshen - Gate release publish on environment approval with a Discord notice ([#1571](#1571)), by @Boshen - Enable `cargo clippy` with `-D warnings` ([#1579](#1579)), by @Boshen - Drop unused `setup-node` from the version-check job ([#1600](#1600)), by @fengmk2 - Add Void deploy workflows for the docs site ([#1590](#1590)), by @fengmk2 - Add `--help` case to config snap tests for npm10/yarn1/yarn4 ([#1585](#1585)), by @jong-kyung - Add `--help` case to publish snap tests for npm10/yarn1/yarn4 ([#1584](#1584)), by @jong-kyung - Verify `.gitignore` and `.yarnrc.yml` in the new-vite-monorepo snap ([#1576](#1576)), by @jong-kyung - vite-task: bump pnpm to `11.1.2` ([vite-task#383](voidzero-dev/vite-task#383)), by @branchseer - vite-task: update lint-staged to v17 ([vite-task#385](voidzero-dev/vite-task#385)), by @renovate[bot] ### Bundled Versions | Tool | Version | Source | | --- | --- | --- | | vite | `8.0.11` | [`66f3194`](vitejs/vite@66f3194) | | rolldown | `1.0.0` | [`ac5c710`](rolldown/rolldown@ac5c710) | | tsdown | `0.22.0` | [npm](https://npmx.dev/package/tsdown/v/0.22.0) | | vitest | `4.1.6` | [npm](https://npmx.dev/package/vitest/v/4.1.6) | | oxlint | `1.63.0` | [npm](https://npmx.dev/package/oxlint/v/1.63.0) | | oxlint-tsgolint | `0.22.1` | [npm](https://npmx.dev/package/oxlint-tsgolint/v/0.22.1) | | oxfmt | `0.48.0` | [npm](https://npmx.dev/package/oxfmt/v/0.48.0) | ### New Contributors Welcome to all new contributors! 🎉 @nozomee, @ryohidaka, @leno23 **Full Changelog**: v0.1.21...v0.1.22 --- Merging this PR will trigger the release workflow. --------- Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com> Co-authored-by: MK <fengmk2@gmail.com>

fengmk2 self-assigned this May 15, 2026

fengmk2 changed the title ~~fix bootstrap cli on Windows~~ chore: fix bootstrap cli on Windows May 15, 2026

fengmk2 force-pushed the fix/windows-bootstrap-cli branch from 65786e2 to 906838b Compare May 16, 2026 06:38

cursor Bot reviewed May 16, 2026

View reviewed changes

fengmk2 marked this pull request as ready for review May 16, 2026 06:48

fengmk2 requested review from Brooooooklyn and branchseer May 16, 2026 06:49

fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests labels May 16, 2026

branchseer approved these changes May 16, 2026

View reviewed changes

fengmk2 force-pushed the fix/windows-bootstrap-cli branch from 906838b to b7f5c76 Compare May 16, 2026 08:46

cursor Bot reviewed May 18, 2026

View reviewed changes

Comment thread packages/tools/src/install-global-cli.ts

fengmk2 added 6 commits May 18, 2026 13:46

fix bootstrap cli on Windows

5a89f9b

format Windows bootstrap fixes

3e7219f

ignore symlink placeholders in formatter

4bc75db

fix test recipe crate scope

b4e3500

handle busy locked vp cleanup

5c9d967

fengmk2 force-pushed the fix/windows-bootstrap-cli branch from 38654b2 to 5c9d967 Compare May 18, 2026 05:47

cursor Bot reviewed May 18, 2026

View reviewed changes

Comment thread packages/tools/src/install-global-cli.ts

handle dangling Windows install junctions

39ebb62

cursor Bot reviewed May 18, 2026

View reviewed changes

fengmk2 merged commit 646ea16 into main May 18, 2026
92 checks passed

fengmk2 deleted the fix/windows-bootstrap-cli branch May 18, 2026 06:06

fengmk2 mentioned this pull request May 19, 2026

release: v0.1.22: Security Patch, Parallel Global Install & Scaffold Polish #1637

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fix bootstrap cli on Windows#1583

chore: fix bootstrap cli on Windows#1583
fengmk2 merged 7 commits into
mainfrom
fix/windows-bootstrap-cli

fengmk2 commented May 15, 2026 •

edited by cursor Bot

Loading

Uh oh!

netlify Bot commented May 15, 2026 •

edited

Loading

Uh oh!

fengmk2 commented May 16, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

fengmk2 commented May 18, 2026

Uh oh!

Uh oh!

fengmk2 commented May 18, 2026

Uh oh!

Uh oh!

fengmk2 commented May 18, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

fengmk2 commented May 15, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Uh oh!

netlify Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

fengmk2 commented May 16, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

fengmk2 commented May 18, 2026

Uh oh!

Uh oh!

fengmk2 commented May 18, 2026

Uh oh!

Uh oh!

fengmk2 commented May 18, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fengmk2 commented May 15, 2026 •

edited by cursor Bot

Loading

netlify Bot commented May 15, 2026 •

edited

Loading