Show memory leak summary when valgrind check fails#570
Show memory leak summary when valgrind check fails#570sshedi wants to merge 1 commit intovmware:devfrom
Conversation
There is a fix in progress for this. |
|
Thank you for this. But how does this fix the valgrind issue? I understand we'll see the error output, but why is it not failing any more? |
579fdbf to
ba811cd
Compare
Fixed it. The error was not captured because I removed exit on first error. |
I am trying to fix a similar issue here: vmware/photon-os-installer#41 |
Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
ba811cd to
363e8a1
Compare
This is also the right thing to do, at some point we will have to align with rpm upstream and consider scriptlet errors as fatal. rpm-6.0.1-3 is published, please rebase #569 |
|
The intention behind this PR is, if we are force merging a PR ignoring memory leaks; we can have a look at the leak summary and decide if it indeed from tdnf or from third party library. |
No description provided.