Skip to content

Combine unit tests and end-to-end tests into one workflow each#19098

Closed
mhamza15 wants to merge 2 commits intovitessio:mainfrom
mhamza15:combined-ci
Closed

Combine unit tests and end-to-end tests into one workflow each#19098
mhamza15 wants to merge 2 commits intovitessio:mainfrom
mhamza15:combined-ci

Conversation

@mhamza15
Copy link
Copy Markdown
Collaborator

@mhamza15 mhamza15 commented Jan 5, 2026

Description

Combines the unit tests and end-to-end tests workflows into one workflow file each. Helps make parsing CI as a human a little easier, and allows us to make more concrete judgements on CI time and potential improvements like sharing work across jobs.

Since the job names are the same, all jobs are still configured as required.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@mhamza15 mhamza15 self-assigned this Jan 5, 2026
@github-actions github-actions Bot added this to the v24.0.0 milestone Jan 5, 2026
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 5, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot Bot commented Jan 5, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@mhamza15 mhamza15 added Component: Build/CI Type: CI/Build and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 5, 2026
@mhamza15 mhamza15 force-pushed the combined-ci branch 2 times, most recently from aaa5083 to c2e7cf3 Compare January 5, 2026 20:07
Combines the unit tests and end-to-end tests workflows into one workflow
file each. Helps make parsing CI as a human a little easier, and allows
us to make more concrete judgements on CI time and potential
improvements.

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2026

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions Bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Feb 5, 2026
@mhamza15 mhamza15 closed this Feb 5, 2026
@mhamza15 mhamza15 deleted the combined-ci branch February 5, 2026 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Build/CI Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant