fix(rsc): fall back on root resolution errors#1309
Draft
nihgwu wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The project-root eligibility check for client-package virtualisation added in #1277 assumes resolution returns null when a package subpath is unavailable from the root. It can instead throw when a different version of the same package exists at the root but does not export the requested subpath.
One real dependency shape is parse5 resolving entities/decode and entities/escape from a nested entities@6, while the application root has entities@4. Resolution from the actual importer is valid, but the root probe aborts the build.
Treat root-probe errors like unresolved or mismatched root results so the plugin falls back to the fully resolved module ID. Add an inline E2E fixture with incompatible root and compatible nested versions, covering both development and production builds.
Follow-up to #1277 and #1295.