Run node tests when coverage is configured for node#11
Open
chrisgervang wants to merge 1 commit intomasterfrom
Open
Run node tests when coverage is configured for node#11chrisgervang wants to merge 1 commit intomasterfrom
node#11chrisgervang wants to merge 1 commit intomasterfrom
Conversation
Contributor
Author
|
This would change deck to run headless-browser tests in ci as well based on this config: https://github.com/visgl/deck.gl/blob/21dcaee23e199ffcb705a1896d8bb87a48abd63e/.ocularrc.js#L48 |
Contributor
Author
|
Here's a test in hubble showing node tests were running: https://github.com/visgl/hubble.gl/actions/runs/13976991475/job/39133098199 Then when I hacked around this the browser tests now run as expected: https://github.com/charlieforward9/hubble.gl/actions/runs/13977630524/job/39135198338 |
Pull Request Test Coverage Report for Build 13977568143Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10