Crateria shinesparks: split speed and general cleanup#2725
Merged
kjbranch merged 7 commits intovg-json-data:masterfrom Feb 27, 2026
Merged
Crateria shinesparks: split speed and general cleanup#2725kjbranch merged 7 commits intovg-json-data:masterfrom
kjbranch merged 7 commits intovg-json-data:masterfrom
Conversation
osse101
previously approved these changes
Feb 27, 2026
| ], | ||
| "exitCondition": { | ||
| "leaveWithSpark": {} | ||
| "leaveWithSpark": {"position": "top"} |
Contributor
There was a problem hiding this comment.
This wouldn't need canHorizontalMidairShinespark and I don't think that is supported. But it would devalue the strat, too.
Contributor
Author
There was a problem hiding this comment.
I'm going to remove top position from this strat right now (which isn't correct), merge this, then start working on a better way to represent this problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up many strats in Crateria.
There were a handful I had Maddo help test in Parlor, which he thought were all too tight ([3, 2], [6, 2], [7, 3], [7, 6])
I also added excessFrames on some, mostly ones that leaveWithSpark
I also removed duplicate requirements, so it doesnt show low-level tech on higher-level strats: