Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Avalonia integration to Avalonia 12, adjusting related project dependencies and examples to compile against the new version.
Changes:
- Bump centralized
$(AvaloniaVersion)to12.0.0-rc1and update related Avalonia example usage. - Update SkiaSharp dependency version and simplify SkiaSharp references in test projects.
- Adjust target frameworks / package references in Avalonia + MAUI projects to accommodate the upgrade.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Updates centralized Avalonia version to 12 RC. |
| CSharpMath.SkiaSharp/CSharpMath.SkiaSharp.csproj | Updates SkiaSharp package version to a preview build. |
| CSharpMath.Rendering.Tests/CSharpMath.Rendering.Tests.csproj | Removes direct SkiaSharp/native-assets references; relies on Avalonia.Skia + project refs. |
| CSharpMath.Maui.Example/CSharpMath.Maui.Example.csproj | Removes direct Microsoft.Maui.Controls ref and disables MAUI implicit package validation. |
| CSharpMath.Avalonia/CSharpMath.Avalonia.csproj | Changes Avalonia front-end TFM from netstandard2.0 to net10.0. |
| CSharpMath.Avalonia.Example/MainWindow.xaml.cs | Removes DEBUG dev-tools attachment. |
| CSharpMath.Avalonia.Example/CSharpMath.Avalonia.Example.csproj | Drops Avalonia.Diagnostics package reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="SkiaSharp" Version="3.119.1" /> | ||
| <PackageReference Include="SkiaSharp" Version="3.119.3-preview.1.1" /> |
There was a problem hiding this comment.
SkiaSharp is updated to a preview package (3.119.3-preview.1.1). Preview dependencies can be unstable and may not be acceptable for a published library package. If this is only needed to match Avalonia 12 RC, consider pinning to a stable SkiaSharp version (if compatible) or clearly isolating/preventing shipping of preview dependencies in release packages.
| <PackageReference Include="SkiaSharp" Version="3.119.3-preview.1.1" /> | |
| <PackageReference Include="SkiaSharp" Version="2.88.6" /> |
There was a problem hiding this comment.
I agree with this review. Either use 3.119.2 or delay the PR until 3.119.3 release.
There was a problem hiding this comment.
charlesroddie
left a comment
charlesroddie
left a comment
There was a problem hiding this comment.
Other than the SkiaSharp version change, no core libraries of CSharpMath are affected. So this PR will be approved when the comment on that version change is resolved.
No description provided.