SYN-10728: Add inet:whois:iprec:org and :org:name properties#4954
Draft
invisig0th wants to merge 1 commit into
Draft
SYN-10728: Add inet:whois:iprec:org and :org:name properties#4954invisig0th wants to merge 1 commit into
invisig0th wants to merge 1 commit into
Conversation
Better capture the organization that registered an IP network by adding explicit :org and :org:name properties to inet:whois:iprec.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4954 +/- ##
==========================================
+ Coverage 97.75% 97.79% +0.03%
==========================================
Files 299 299
Lines 63362 63362
==========================================
+ Hits 61942 61965 +23
+ Misses 1420 1397 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inet:whois:iprec:org(ou:org) andinet:whois:iprec:org:name(ou:name) to explicitly capture the organization that registered an IP network.inet:whois:iprec:registrantremains deprecated (unchanged).Ref: SYN-10728
Test plan
test_whois_iprecextended to set/check:organd:org:namesynapse/tests/test_model_inet.pypasses locally (71/71)