SYN-3465: Storm Package Uninstall Hook

[MichaelSquires]

Core Logic (synapse/cortex.py — +225 lines)

• New uninstallStormPkg() API — graceful uninstall by name with an optional keep list to preserve specific resources (pkg-vars, vaults, dmons, queues, model)
• onuninstall hook — runs a Storm query from the package definition before cleanup, passing the keep list as a variable
• _cleanupStormPkg() — automatically deletes dmons, queues, vaults, package variables, and extended model elements (types, forms, props, tag props) unless kept
• Onload task tracking — _pkgOnloadTasks dict tracks async onload tasks so they can be cancelled during delete/uninstall
• _loadStormPkgDmons() — packages can now declaratively define dmons that are auto-created after onload
• Guard against re-install during uninstall — blocks addStormPkg if _uninstalling flag is set
• Startup recovery — resumes in-progress uninstalls on Cortex restart

Schema (synapse/lib/schemas.py — +104 lines)

• Added onuninstall, dmons, and model fields to the package definition JSON schema
• model supports declarative types, forms, props, and tagprops

Storm CLI (synapse/lib/stormlib/pkg.py — +63 lines)

• pkg.del --uninstall flag triggers the new uninstall flow
• --uninstall-keep argument to specify resources to preserve
• pkg.list shows uninstall status for in-progress uninstalls

Supporting Changes

• Tests — +1134 lines in test_lib_stormlib_pkg.py covering uninstall, keep options, model cleanup, dmon lifecycle, onuninstall hooks, restart recovery, and error cases.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (c3aaad9) to head (14ae8ef).

Additional details and impacted files

@@               Coverage Diff               @@
##           synapse-3xx    #4840      +/-   ##
===============================================
+ Coverage        96.23%   96.25%   +0.01%     
===============================================
  Files              259      259              
  Lines            63244    63433     +189     
===============================================
+ Hits             60866    61059     +193     
+ Misses            2378     2374       -4     

Flag	Coverage Δ
linux	96.25% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mikemoritz]

Similar to the question about safemode, won't the uninstall still complete even it "failed"?

[mikemoritz]

I can imagine the things we are storing in storm pkgvars could grow over time, so maybe we would want a delStormPkgVarKV so its just one nexus txn?

[MichaelSquires]

I can open a ticket for this.