Open
Conversation
vEpiphyte
reviewed
Jan 20, 2026
vEpiphyte
reviewed
Jan 20, 2026
vEpiphyte
reviewed
Jan 21, 2026
vEpiphyte
reviewed
Jan 21, 2026
- Updated logging examples in devops documentation. - Updates to ``synapse.lib.nexus`` - the current scope is cloned onto the apply task. - Updates to ``synapse.lib.logging`` - Added a `shutdown()` API which causes the log pump to wake up, drain existing todo items, then exit. This is needed for application / command shutdown so we don't await the bg task. - Added ``BaseExceptionGroup`` handling to ``excinfo``. - Fixed Garbage Collection issue in ``_pumpLogStream``; the last window objects in ``_log_wins`` was held onto and would not be GC'd even if its calling task was completed. - HTTP API request logs now use the web_user / web_username to populate the user information when logging a request. - HTTP API auth failure logs now record the user & username as target_user and target_username. - ``Base.main()`` now calls ``logging.shutdown()``. - ``synapse.lib.cmd.wrapmain()`` now calls ``logging.shutdown()``. - Updated all existing uses of ``extra=...`` definitions to use the new ``getLogExtra`` APIs so there would not be a regression in logged parameters. - Rewrote ``test_lib_logging.py`` to increase coverage and add more focused behavioral tests. - Changed ``LoggerStream.expect()`` to raise an ``AssertionError`` instead of a ``SynErr`` to avoid the possibility of a test catching a ``SynErr`` by mistake when they wanted a test assertion to fail. - Remove ``synapse.lib.structlog`` module and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.