Replace ThreadLocals and add v thread ctx pooling by franz1981 · Pull Request #9 · vert-x3/vertx-virtual-threads-incubator

franz1981 · 2023-05-30T07:49:16Z

No description provided.

franz1981 · 2023-05-30T07:50:06Z

@vietj Still not sure about the added test: I was expecting it to cause some external unpark, while it doesn't seem the case

in the new freshly created ctx

doctorpangloss · 2023-09-19T15:03:40Z

    scheduler.execute(() -> {
-      inThread.set(true);
+      var current = Thread.currentThread();
+      inThread.add(current);


I adopted this fix separately in my fork, it's an essential one

doctorpangloss · 2023-09-19T15:04:28Z

   * Run a task on a virtual thread
   */
  public void run(Handler<Void> task) {
+    assert !Thread.currentThread().isVirtual();


I actually expect to be able to call .run from a virtual thread all the time

Replace ThreadLocals

7d4f081

Add few comments and add pooling of v thread ctx

20ed13d

in the new freshly created ctx

franz1981 force-pushed the main_fix branch from c1d2f35 to 20ed13d Compare May 30, 2023 07:51

doctorpangloss reviewed Sep 19, 2023

View reviewed changes

Provide feedback