Feature/producer transceiver inactive on pause#176
Open
tdrz wants to merge 12 commits intoversatica:v3from
Open
Feature/producer transceiver inactive on pause#176tdrz wants to merge 12 commits intoversatica:v3from
tdrz wants to merge 12 commits intoversatica:v3from
Conversation
ibc
reviewed
May 27, 2024
Member
ibc
left a comment
ibc
left a comment
There was a problem hiding this comment.
Thanks. We cannot merge this until we finish the upgrade to libwebrtc M120 (or another version, I don't remember) which is being done in another PR. Once done we will take care of this PR.
Contributor
Author
|
Could you please have a look if this can be merged now? |
Member
Please run |
Contributor
Author
|
Ok, will do, but probably only next week at the earliest. |
Contributor
Author
|
I just ran |
Member
|
Have you built this branch against m120? It's failing to me https://mediasoup.org/documentation/v3/libmediasoupclient/installation/ |
Contributor
Author
|
Updated now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analogous to versatica/mediasoup-client#215
I've tested it a bit with my own app, looks OK.
I am a bit puzzled by the fact that my encoder is immediately reinitialized after being released upon setting the stream inactive. But the encoding method is not called, which is good.