Fix UpdateIceServers method parameters format#167
Open
fedulvtubudul wants to merge 3 commits intoversatica:v3from
Open
Fix UpdateIceServers method parameters format#167fedulvtubudul wants to merge 3 commits intoversatica:v3from
fedulvtubudul wants to merge 3 commits intoversatica:v3from
Conversation
ibc
reviewed
Aug 12, 2023
Member
ibc
left a comment
ibc
left a comment
There was a problem hiding this comment.
Will check this PR and the website related in next weeks. Thanks.
fedulvtubudul
force-pushed
the
fix-updateiceservers-format
branch
from
eb1fb68 to
5272226
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iceServerUrisparameter parsing logic inUpdateIceServersmethod in its current state suggests that the parameter is an array of strings.Documentation suggests that this parameter is an array of RTCIceServer structures. TS implementation uses same structure as far as I can see.
I've had part of this changes in my fork for the last year, but now I've decided to make a PR, so I added relevant test case and made parsing logic more general to support everything documentation describes.