docs: fix stale testing section, broken publishing link, and add agent-team troubleshooting#119
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
…t-team troubleshooting CONTRIBUTING.md Testing section claimed "there is no automated test harness" — factually wrong since tests/ has a full three-tier suite (invariants, skill tests, E2E). Replaced with accurate description and quick-start commands pointing to tests/README.md. Fixed a broken cross-reference: "Publishing section of the README" linked to README.md#publishing, which does not exist. Replaced with an inline description of the maintainer publishing steps. catalog/agent-team/README.md: expanded "Kicking off a task" step 5 to cover all three recovery paths for a blocked issue — reviewer kickback, the new "inputs not propagated" fail-loud state introduced in PR #69, and full-restart from scratch. Previously, only the label-re-add path was documented, which is the wrong recovery for input-propagation failures (re-adding the label does nothing when a spec already exists). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
automation
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by the
update-docsworkflow after PR #69 merged. Three documentation gaps identified and fixed.What changed
CONTRIBUTING.md— Testing section rewrittenThe section opened with
"There is no automated test harness"— factually wrong sincetests/ships a full three-tier suite (Tier 2 invariants, Tier 1 skill tests, Tier 3 E2E). Replaced with accurate quick-start commands and tier descriptions pointing totests/README.md.CONTRIBUTING.md— Broken publishing cross-referencePublishing (maintainers only)linked toREADME.md#publishing, a section that does not exist. Replaced with an inline description of the maintainer publishing steps (bumpplugin.json, create a GitHub Release, submit to external registries).catalog/agent-team/README.md— Troubleshooting for blocked issuesPR #69 introduced a "fail loud" behavior: when a manual
workflow_dispatchruns without required inputs, the agent now posts🛑 agent-team: workflow_dispatch inputs were not propagatedand blocks the issue. The existing "Retrying a blocked task" step only documented label re-add, which is the wrong recovery path for this case (the spec agent immediately exits when a spec already exists).Expanded step 5 to cover all three recovery paths:
gh workflow runwith correct-fflags-fflag list per roleTesting
./tests/test-invariants.sh— all 27 assertions pass (no forbidden phrases introduced, required phrases still present,$\{\{ github.event.inputs.* }}still incatalog/agent-team/README.md).mdfiles changed — Tier 1 tests unaffected